Change in vdsm[master]: vm: snapshot - adding appropriate logs

derez at redhat.com derez at redhat.com
Thu Dec 31 10:12:23 UTC 2015


Daniel Erez has posted comments on this change.

Change subject: vm: snapshot - adding appropriate logs
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50775/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3247:                 freezed = self.freeze()
Line 3248:             try:
Line 3249:                 self.log.info("Taking a snapshot with drives %s (memory=%s).",
Line 3250:                               ', '.join(map(lambda d: d[1]['name'],
Line 3251:                                             newDrives.iteritems())),
> For consistency, lets use:
Done
Line 3252:                               memoryParams is not None)
Line 3253:                 self._dom.snapshotCreateXML(snapxml, snapFlags)
Line 3254:                 self.log.info("Completed live snapshot.")
Line 3255:             except libvirt.libvirtError:


-- 
To view, visit https://gerrit.ovirt.org/50775
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3e948863f762de9cfc281bdff1fc92c88b678d75
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list