Change in vdsm[master]: network: tests: mirror drop inital ip tests

danken at redhat.com danken at redhat.com
Tue Dec 29 15:58:01 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: network: tests: mirror drop inital ip tests
......................................................................


network: tests: mirror drop inital ip tests

Rename test_remove_initial_network_nic_ip_config to
test_drop_initial_network_nic_ip_config, to be uniform with
test_drop_initial_network_bond_ip_config.

Use self.assertNotIn(IPv6_ADDRESS_AND_CIDR, ipv6addrs)
instead of self.assertEqual([], ipv6addrs), it will prevent
possible errors caused by IPv6 link-local address assigned
by default, also it is what we assign in
test_drop_initial_network_nic_ip_config.

Change-Id: I042b45de389c5a0faca5f913eac9691ae3d6069b
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50713
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-by: Edward Haas <edwardh at redhat.com>
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Continuous-Integration: Jenkins CI
---
M tests/functional/networkTests.py
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/50713
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I042b45de389c5a0faca5f913eac9691ae3d6069b
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list