Change in vdsm[master]: netconf: own /var/run/vdsm/netconf as well

danken at redhat.com danken at redhat.com
Mon Dec 28 14:07:53 UTC 2015


Hello Anatoly Litovsky,

I'd like you to do a code review.  Please visit

    https://gerrit.ovirt.org/51125

to review the following change.

Change subject: netconf: own /var/run/vdsm/netconf as well
......................................................................

netconf: own /var/run/vdsm/netconf as well

commit 1fa3b3 made /var/run/vdsm/netconf/nets owned by vdsm, but
sometimes we have /var/run/vdsm/netconf/ still owned by root.

Bug-Url: https://bugzilla.redhat.com/1293617
Change-Id: I94191063b798ce61660a2868010fa9654ce48c08
Signed-off-by: Tolik Litovsky <tlitovsk at redhat.com>
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/netconfpersistence.py
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/25/51125/1

diff --git a/lib/vdsm/netconfpersistence.py b/lib/vdsm/netconfpersistence.py
index 5912b97..82f0b15 100644
--- a/lib/vdsm/netconfpersistence.py
+++ b/lib/vdsm/netconfpersistence.py
@@ -167,6 +167,7 @@
 
         # Set owner to vdsm (required by ovirt-node)
         vdsm_uid = pwd.getpwnam(constants.VDSM_USER).pw_uid
+        os.chown(os.path.dirname(dirPath), vdsm_uid, 0)
         os.chown(dirPath, vdsm_uid, 0)
         os.chown(path, vdsm_uid, 0)
 


-- 
To view, visit https://gerrit.ovirt.org/51125
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I94191063b798ce61660a2868010fa9654ce48c08
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Anatoly Litovsky <tlitovsk at redhat.com>


More information about the vdsm-patches mailing list