Change in vdsm[master]: v2v: externalVMList Xen+Kvm support

shavivi at redhat.com shavivi at redhat.com
Sun Dec 27 09:27:08 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: v2v: externalVMList Xen+Kvm support
......................................................................


Patch Set 22:

(1 comment)

https://gerrit.ovirt.org/#/c/48672/22/vdsm/v2v.py
File vdsm/v2v.py:

Line 638:     try:
Line 639:         for vm in conn.listAllDomains():
Line 640:             yield vm
Line 641:     except libvirt.libvirtError as e:
Line 642:         if e.get_error_code() != libvirt.VIR_ERR_NO_SUPPORT:
> Did you test this logic with old versions? does it fail as we expect and fa
yes, 
the Xen api via rhel 5.x works
Line 643:             raise
Line 644:         seen = set()
Line 645:         # Support for old libvirt clients
Line 646:         for name in conn.listDefinedDomains():


-- 
To view, visit https://gerrit.ovirt.org/48672
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ic7d7e211a9343a528f260da2686b34cea00c53a4
Gerrit-PatchSet: 22
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Eric Blake <eric.b.blake at gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Michal Skrivanek <mskrivan at redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list