Change in vdsm[master]: JSONRPC: make Image.prepare to return info.

nsoffer at redhat.com nsoffer at redhat.com
Thu Dec 24 15:55:57 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: JSONRPC: make Image.prepare to return info.
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/51054/3/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 5224: ##
Line 5225: {'command': {'class': 'Image', 'name': 'prepare'},
Line 5226:  'data': {'storagepoolID': 'UUID', 'storagedomainID': 'UUID',
Line 5227:           'imageID': 'UUID', 'volumeID': 'UUID'}
Line 5228:  'returns': 'ImageInfo'}}
But where is this type defined?

You must add this type, see VolumeInfo for example.
Line 5229: 
Line 5230: ##
Line 5231: # @Image.teardown:
Line 5232: #


-- 
To view, visit https://gerrit.ovirt.org/51054
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icc03568b35c14e1f5c7239c8c3df8f74acf3ec51
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Sivák <msivak at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Simone Tiraboschi <stirabos at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list