Change in vdsm[master]: build: Add dependencies for generated .py files

danken at redhat.com danken at redhat.com
Thu Dec 24 12:44:17 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: build: Add dependencies for generated .py files
......................................................................


build: Add dependencies for generated .py files

In the past we checked .py.in files with pep8 and pyflakes. Recently we
removed this wrong check, and we are checking only .py files.

This change required running "make; make check", to have .py files
generated before running make check.

This patch adds dependencies so "make check" will generated the files it
wants to check.

Searching for .py.in file is not needed now and was removed.

Change-Id: I57eeba76a5e07a1edeae6869e103547347e874cf
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50299
Continuous-Integration: Jenkins CI
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M Makefile.am
M automation/check-patch.sh
2 files changed, 6 insertions(+), 10 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50299
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I57eeba76a5e07a1edeae6869e103547347e874cf
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list