Change in vdsm[master]: net api: Normalize 'remove' for networks to boolean

danken at redhat.com danken at redhat.com
Thu Dec 24 12:02:39 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net api: Normalize 'remove' for networks to boolean
......................................................................


net api: Normalize 'remove' for networks to boolean

Normalize 'remove' value to a boolean at the api entry point.
The incosistent value type caused validation failures of the
api, especially when the canonization step has been introduced.

Change-Id: I411458ee7847685873d19dfc595f10f609154b43
Signed-off-by: Edward Haas <edwardh at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/51041
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/network/api.py
1 file changed, 9 insertions(+), 4 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/51041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I411458ee7847685873d19dfc595f10f609154b43
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list