Change in vdsm[master]: guestagent: Simplify and modernize object filtering

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 23 23:24:06 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: guestagent: Simplify and modernize object filtering
......................................................................

guestagent: Simplify and modernize object filtering

Simplify and modernize object filtering by using dict and list
comprehensions.  This creates less garbage while building a filtered
object, and give minor performance improvement (35%).

Change-Id: I753d97ffe992400728aebed0352661306a1619c7
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/virt/guestagent.py
1 file changed, 2 insertions(+), 4 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/39/51039/1

diff --git a/vdsm/virt/guestagent.py b/vdsm/virt/guestagent.py
index 81f7746..f88ef59 100644
--- a/vdsm/virt/guestagent.py
+++ b/vdsm/virt/guestagent.py
@@ -79,11 +79,9 @@
     """
     def filt(o):
         if isinstance(o, dict):
-            return dict(map(filt, o.iteritems()))
+            return {filt(k): filt(v) for k, v in o.iteritems()}
         elif isinstance(o, list):
-            return map(filt, o)
-        elif isinstance(o, tuple):
-            return tuple(map(filt, o))
+            return [filt(i) for i in o]
         elif isinstance(o, basestring):
             return _filterXmlChars(o)
         return o


-- 
To view, visit https://gerrit.ovirt.org/51039
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I753d97ffe992400728aebed0352661306a1619c7
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list