Change in vdsm[master]: storage: Split newMetadata into makeMetadata and createMetadata

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 23 22:21:59 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: Split newMetadata into makeMetadata and createMetadata
......................................................................


Patch Set 14: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/44045/14/vdsm/storage/volume.py
File vdsm/storage/volume.py:

Line 522
Line 523
Line 524
Line 525
Line 526
This separation makes sense, although I did not see the other place using the new method yet, but the names are very confusing.


Line 533:         return meta
Line 534: 
Line 535:     @classmethod
Line 536:     def makeMetadata(cls, sdUUID, imgUUID, puuid, size, format, type,
Line 537:                      voltype, disktype, desc="", legality=ILLEGAL_VOL):
The name is confusing. This return a metadata dict that can be used to create newMetadata, or for some other purpose.

How about newMetadict?
Line 538:         """
Line 539:         Produce a metadata dictionary from a set of arguments.
Line 540:         """
Line 541:         return {


-- 
To view, visit https://gerrit.ovirt.org/44045
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I028996b3a5967f96a103f0b03d6b8f82b25da888
Gerrit-PatchSet: 14
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram at redhat.com>
Gerrit-Reviewer: Daniel Erez <derez at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Greg Padgett <gpadgett at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: Vered Volansky <vvolansk at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list