Change in vdsm[master]: fileSD: fix deleteImage flow

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 23 15:07:17 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: fileSD: fix deleteImage flow
......................................................................


Patch Set 4:

(3 comments)

https://gerrit.ovirt.org/#/c/50804/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-12-20 17:01:50 +0200
Line 4: Commit:     Idan Shaby <ishaby at redhat.com>
Line 5: CommitDate: 2015-12-23 10:15:54 +0200
Line 6: 
Line 7: fileSD: fix deleteImage flow
fix deleteImage flow is too generic. I would call it "improve error handling in deleteImage"
Line 8: 
Line 9: In FileStorageDomainManifest.deleteImage, we used to log that the volume
Line 10: could not be removed even if it was removed but the metadata/lease file
Line 11: could not be removed afterwards.


Line 7: fileSD: fix deleteImage flow
Line 8: 
Line 9: In FileStorageDomainManifest.deleteImage, we used to log that the volume
Line 10: could not be removed even if it was removed but the metadata/lease file
Line 11: could not be removed afterwards.
Separate paragraphs with blank line.
Line 12: This patch logs more informative errors about the specific file that
Line 13: could not be removed. If the removal fails because the file doesn't
Line 14: exist, we log a warning. Otherwise, we log an error message that the
Line 15: file can't be removed.


Line 16: 
Line 17: Also, if one of the files couldn't be removed, we didn't try to remove
Line 18: the others.
Line 19: Now we handle each removal separately, so that a failure in the removal
Line 20: of one file doesn't affect the removal of the others.
Please rewrap, this looks like one paragraph.
Line 21: 
Line 22: Bug-Url: https://bugzilla.redhat.com/1292092
Line 23: Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369


-- 
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list