Change in vdsm[master]: v2v: refactor testSuccessfulImport test

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 23 14:45:24 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: refactor testSuccessfulImport test
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/50584/3/tests/v2vTests.py
File tests/v2vTests.py:

Line 335:                 job.wait()
Line 336: 
Line 337:                 self.assertEqual(job.status, v2v.STATUS.DONE)
Line 338:             finally:
Line 339:                 v2v._jobs.clear()
Lets add the tearDown() you added in next patch in this patch, and remove the try finally.
Line 340: 
Line 341:     def testV2VOutput(self):
Line 342:         cmd = [FAKE_VIRT_V2V.cmd,
Line 343:                '-ic', self.url,


-- 
To view, visit https://gerrit.ovirt.org/50584
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I30144a9f03d1d95837f43d8b5575aae1499d3c2a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list