Change in vdsm[master]: v2v: refactor get_external_vms
nsoffer at redhat.com
nsoffer at redhat.com
Wed Dec 23 14:35:18 UTC 2015
Nir Soffer has posted comments on this change.
Change subject: v2v: refactor get_external_vms
......................................................................
Patch Set 5:
(1 comment)
https://gerrit.ovirt.org/#/c/49636/5/vdsm/v2v.py
File vdsm/v2v.py:
Line 646: try:
Line 647: try:
Line 648: _add_vm_info(vm, params)
Line 649: except libvirt.libvirtError as e:
Line 650: logging.exception("error getting domain information")
> well it conflict with what Francesco asked here when then patch is made:
Francesco is right, that you don't need to log the exception object when using logging.exception(), but I suggest to use logging.error(), and this case logging the original error is a must.
Line 651: return
Line 652: try:
Line 653: xml = vm.XMLDesc(0)
Line 654: except libvirt.libvirtError as e:
--
To view, visit https://gerrit.ovirt.org/49636
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If5c331b3136b61b0ee81829d7e71eedbbc1fa6b9
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list