Change in vdsm[master]: net: Update mtu under the bridge only when needed
danken at redhat.com
danken at redhat.com
Wed Dec 23 11:09:24 UTC 2015
Dan Kenigsberg has posted comments on this change.
Change subject: net: Update mtu under the bridge only when needed
......................................................................
Patch Set 3: Code-Review-1
(1 comment)
https://gerrit.ovirt.org/#/c/50790/3/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:
Line 246: _update_bridge_ports_mtu
do we really want to keep this function? shouldn't it be inlined? at the very least it should be placed near its single caller.
--
To view, visit https://gerrit.ovirt.org/50790
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f26d1d6ddbb5ed1e7ecb4f6d7df1c185bccecc0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list