Change in vdsm[master]: hooks: ovs: show vlan in caps ports

phoracek at redhat.com phoracek at redhat.com
Tue Dec 22 12:49:09 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: hooks: ovs: show vlan in caps ports
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/50730/5/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

Line 71:         'dhcpv6': dhcpv6,
Line 72:         'cfg': {'BOOTPROTO': 'dhcp' if dhcpv4 else 'none'}}
Line 73: 
Line 74: 
Line 75: def _get_ports(network, attrs):
> this is a little complicated. can you add a doc string?
Done
Line 76:     top_device = network if 'vlan' in attrs else BRIDGE_NAME
Line 77:     physical_interface = attrs.get('bonding') or attrs.get('nic')
Line 78:     assigned_port = ('%s.%s' % (physical_interface, attrs.get('vlan'))
Line 79:                      if 'vlan' in attrs else physical_interface or None)


Line 76:     top_device = network if 'vlan' in attrs else BRIDGE_NAME
Line 77:     physical_interface = attrs.get('bonding') or attrs.get('nic')
Line 78:     assigned_port = ('%s.%s' % (physical_interface, attrs.get('vlan'))
Line 79:                      if 'vlan' in attrs else physical_interface or None)
Line 80:     ports = (list(set(_list_ports(top_device).append(assigned_port)))
> can _list_ports return duplicates? if not, this is a little more confusing 
Done
Line 81:              if assigned_port else _list_ports(top_device))
Line 82:     return ports
Line 83: 
Line 84: 


-- 
To view, visit https://gerrit.ovirt.org/50730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list