Change in vdsm[master]: vm.py: Fixed typo speficy->specify

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 22 11:50:54 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: vm.py: Fixed typo speficy->specify
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50855/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 3066:             # Libvirt versions before 1.2.2 do not understand 'type' and treat
Line 3067:             # all snapshots as if they are type='file'.  In order to ensure
Line 3068:             # proper handling of block snapshots in modern libvirt versions,
Line 3069:             # we specify type='block' and dev=path for block volumes but we
Line 3070:             # always specify the file=path for backwards compatibility.
We require now libvirt 1.2.8, so this comment and the code it explains are not needed any more.
Line 3071:             args = {'type': sourceType, 'file': newPath}
Line 3072:             if sourceType == 'block':
Line 3073:                 args['dev'] = newPath
Line 3074:             disk.appendChildWithArgs('source', **args)


-- 
To view, visit https://gerrit.ovirt.org/50855
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Icba0f7ccc2aabb83c03076ff5290518d063f9d25
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list