Change in vdsm[master]: supervdsm: moving nics between bonds

ibarkan at redhat.com ibarkan at redhat.com
Tue Dec 22 11:32:20 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: supervdsm: moving nics between bonds
......................................................................


Patch Set 2:

(2 comments)

https://gerrit.ovirt.org/#/c/50596/2/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 707: existing_slaves = set(_netinfo.bondings[name]['slaves'])
        :         removed_slaves = existing_slaves - set(attrs.get('nics'))
please separate the computation of what needs to be removed to a different function and pass it's result to here


Line 710: _netinfo.bondings[name]['slaves'] = existing_slaves - removed_slaves
this is frowned upon. please call updateDevices to refresh _netinfo state. Linux network changes has the tendency to have surprising side affects.


-- 
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list