Change in vdsm[master]: hooks: ovs: show vlan in caps ports

ibarkan at redhat.com ibarkan at redhat.com
Tue Dec 22 08:45:03 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: hooks: ovs: show vlan in caps ports
......................................................................


Patch Set 5:

(2 comments)

https://gerrit.ovirt.org/#/c/50730/5/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

Line 75: _get_ports
this is a little complicated. can you add a doc string?
what should _list_ports return in the cases of top_device?


Line 80: _list_ports
can _list_ports return duplicates? if not, this is a little more confusing then:
  if x not in l:
    l.append(x)


-- 
To view, visit https://gerrit.ovirt.org/50730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list