Change in vdsm[master]: supervdsm: moving nics between bonds
edwardh at redhat.com
edwardh at redhat.com
Tue Dec 22 07:48:10 UTC 2015
Edward Haas has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
......................................................................
Patch Set 1:
Ido and myself have reread your solution, and we would like to propose a different direction.
A cleaner way would be to implement the following algorithm right before the edition loop in _handleBondings (line 683 in api.py):
slaves = _compute_migrated_slaves(...) # if you have a better name, go for it.
_remove_slaves(slaves)
_netinfo.updatedevices() # important!
...
def _remove_slaves(slaves)
for s in slaves:
Nic(..., s, ...).remove()
Ideally, this should be the only needed change, and the bond.objectivize(...) call inside the following loop should just work- since it only relies on _netinfo.
--
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No
More information about the vdsm-patches
mailing list