Change in vdsm[master]: fileSD: fix deleteImage flow

ishaby at redhat.com ishaby at redhat.com
Mon Dec 21 14:04:58 UTC 2015


Idan Shaby has posted comments on this change.

Change subject: fileSD: fix deleteImage flow
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 215:             volPath = os.path.join(toDelDir, volUUID)
Line 216:             self._deleteFile("volume", volPath)
Line 217:             self._deleteFile("metadata", volPath + '.meta')
Line 218:             if self.hasVolumeLeases():
Line 219:                 self._deleteFile("lease", volPath + '.lease')
> Before this patch, the flow will stop after the first failure. Here it will
Yes
Line 220:         self.log.debug("Removing directory: %s", toDelDir)
Line 221:         try:
Line 222:             self.oop.os.rmdir(toDelDir)
Line 223:         except OSError as e:


-- 
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list