Change in vdsm[master]: fileSD: fix deleteImage flow

frolland at redhat.com frolland at redhat.com
Mon Dec 21 13:48:06 UTC 2015


Freddy Rolland has posted comments on this change.

Change subject: fileSD: fix deleteImage flow
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50804/1/vdsm/storage/fileSD.py
File vdsm/storage/fileSD.py:

Line 216: self._deleteFile("volume", volPath)
        :             self._deleteFile("metadata", volPath + '.meta')
        :             if self.hasVolumeLeases():
        :                 self._deleteFile("lease", volPath + '.lease')
Before this patch, the flow will stop after the first failure. Here it will try to delete the next file even if the one before failed.
Is it what we want to do ?


-- 
To view, visit https://gerrit.ovirt.org/50804
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9eeb28a70f708a4f9a5effe4ff294da63b757369
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Idan Shaby <ishaby at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Tal Nisan <tnisan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list