Change in vdsm[master]: hooks: ovs: rename _set/drop/remove_ip_config functions

danken at redhat.com danken at redhat.com
Mon Dec 21 12:15:08 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: hooks: ovs: rename _set/drop/remove_ip_config functions
......................................................................


hooks: ovs: rename _set/drop/remove_ip_config functions

Make difference between _drop_ip_config, _remove_ip_config and
_set_ip_config more explicit by renaming and adding extra comments.

Change-Id: I0489b7679577e2e038d46f025db75168986f3a49
Signed-off-by: Petr Horáček <phoracek at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50260
Continuous-Integration: Jenkins CI
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M vdsm_hooks/ovs/ovs_before_network_setup_ip.py
1 file changed, 11 insertions(+), 9 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Petr Horáček: Verified
  Dan Kenigsberg: Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50260
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0489b7679577e2e038d46f025db75168986f3a49
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list