Change in vdsm[master]: net: Compare kernel vs running bond config opt vals

danken at redhat.com danken at redhat.com
Mon Dec 21 07:31:45 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: net: Compare kernel vs running bond config opt vals
......................................................................


net: Compare kernel vs running bond config opt vals

Comparing between the bond running config and the
bond kernel config should consider that some values
may be inputted as name or numeric.
A dictionary is kept to translate between the name
and its numeric value.

The running config bonding option values are normalized
to their numeric values and compared to the kernel
config which represents the values as numeric.

Change-Id: I0f334a7ae2ecd8fc75c05972e37d539cf7c28661
Signed-off-by: Edward Haas <edwardh at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/49579
Reviewed-by: Ido Barkan <ibarkan at redhat.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Dan Kenigsberg <danken at redhat.com>
---
M lib/vdsm/kernelconfig.py
M tests/functional/networkTests.py
2 files changed, 8 insertions(+), 2 deletions(-)

Approvals:
  Ido Barkan: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Looks good to me, approved
  Edward Haas: Verified



-- 
To view, visit https://gerrit.ovirt.org/49579
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I0f334a7ae2ecd8fc75c05972e37d539cf7c28661
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list