Change in vdsm[master]: net: Mapping bonding option value names to numerics

ibarkan at redhat.com ibarkan at redhat.com
Sun Dec 20 09:39:15 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: Mapping bonding option value names to numerics
......................................................................


Patch Set 25:

(1 comment)

https://gerrit.ovirt.org/#/c/49390/25/lib/vdsm/tool/dump_bonding_opts.py
File lib/vdsm/tool/dump_bonding_opts.py:

Line 82: with _bond_device(bond_name):
> _scan_modes uses _change_mode to set the bond mode.
you are right. I midssed that. but on second look- the code should still have one less context level.
it should look like this (conceptually):

  for mode in bond_modes:
      # explain why we replace bond at this level
      with bond(mode):
          opts[mode] = bond_opts_name2numeric_filtered(bond name)

This will eliminate the below addition in the beginning of _change_mode


-- 
To view, visit https://gerrit.ovirt.org/49390
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f4c16b1523822a2d53d4525841ff8741af6296c
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list