Change in vdsm[master]: storage: add getHostId to DomainMonitor

nsoffer at redhat.com nsoffer at redhat.com
Fri Dec 18 18:29:36 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: storage: add getHostId to DomainMonitor
......................................................................


storage: add getHostId to DomainMonitor

Some SDM verbs need to acquire the domainLock during their job.  In
order to do this they must be passed the domain's hostId property.  An
easy way to expose this is to add a getHostId method to the
DomainMonitor.

Another method (not chosen) is for IRS to access the host id via the
StorageDomainManifest.getPools method:

    dom_manifest.getPools()[0].id

The main reason for using the domainMonitor is to avoid adding any new
users of the StoragePool class.  Since the domainMonitor acquires the
hostID via SANLock, it seems qualified to communicate that hostID to its
owner.

Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50630
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
---
M vdsm/storage/monitor.py
1 file changed, 3 insertions(+), 0 deletions(-)

Approvals:
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list