Change in vdsm[master]: hooks: ovs: list all attached nics in caps ports

danken at redhat.com danken at redhat.com
Fri Dec 18 17:33:28 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: hooks: ovs: list all attached nics in caps ports
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50730/1/vdsm_hooks/ovs/ovs_after_get_caps.py
File vdsm_hooks/ovs/ovs_after_get_caps.py:

Line 86:         # port assigned to tagged network has no tag in openvswitch database
Line 87:         # (we leave it untagged, so we are able to set up multiple vlans over
Line 88:         # one physical interface). such nic is not listed by _list_ports and
Line 89:         # therefore we have to add it explicitly.
Line 90:         port = attrs.get('bond') or attrs.get('nic')
Port can end up being None (nicless network)
Line 91:         net_info['ports'] = list(set(_list_ports(interface).append(port)))
Line 92:         net_info['stp'] = _get_stp(interface)
Line 93:         ovs_networks_caps[network] = net_info
Line 94:     return ovs_networks_caps


-- 
To view, visit https://gerrit.ovirt.org/50730
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ica2082907035c22e72115a684f358fcbe8a8056e
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list