Change in vdsm[master]: gluster: Handle missing glusterfs-cli package

nsoffer at redhat.com nsoffer at redhat.com
Fri Dec 18 00:21:11 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: gluster: Handle missing glusterfs-cli package
......................................................................


Patch Set 12: Code-Review+1

(1 comment)

Looks good, just minor issue in test name.

https://gerrit.ovirt.org/#/c/50363/12/tests/storageServerTests.py
File tests/storageServerTests.py:

Line 243:         gluster = GlusterFSConnection(spec="192.168.122.1:/music")
Line 244:         gluster.validate()
Line 245: 
Line 246:     @MonkeyPatch(gluster.cli, 'exists', lambda: False)
Line 247:     def test_glusterfs_cli_not_exists(self):
"not exists" -> "does not exist", or "missing"
Line 248:         gluster = GlusterFSConnection(spec="192.168.122.1:/music")


-- 
To view, visit https://gerrit.ovirt.org/50363
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9c33aa33e4ffe6a382d40e1bc63f6735efcfcd1f
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list