Change in vdsm[master]: Always propagate bonding mode to engine

sshnaidm at redhat.com sshnaidm at redhat.com
Thu Dec 17 16:13:39 UTC 2015


Sagi Shnaidman has posted comments on this change.

Change subject: Always propagate bonding mode to engine
......................................................................


Patch Set 5:

(3 comments)

https://gerrit.ovirt.org/#/c/49580/5/lib/vdsm/kernelconfig.py
File lib/vdsm/kernelconfig.py:

Line 231: if "mode" not in normalized_opts:
        :             normalized_opts["mode"] = '0'
> why is this change needed? kernelConfig has nothing to do with reporting to
it's for functional network tests, for function _assert_kernel_config_matches_running_config


https://gerrit.ovirt.org/#/c/49580/5/lib/vdsm/netinfo/bonding.py
File lib/vdsm/netinfo/bonding.py:

Line 83: Return non-empty options differing from defaults, excluding not actual or
       :     not applicable options, e.g. 'ad_num_ports' or 'slaves'.
> function doc should be updated
Done


https://gerrit.ovirt.org/#/c/49580/5/tests/functional/networkTests.py
File tests/functional/networkTests.py:

Line 2668: test_bondmode_in_capabilities
> +1 for testing!
I think in this special case the functional test makes more sense, we can see exactly what operation system does and can check it more strictly.


-- 
To view, visit https://gerrit.ovirt.org/49580
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4883022420092d822419fa3b7b9fae50741dd360
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Sagi Shnaidman <sshnaidm at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list