Change in vdsm[master]: net: MTU should be an integer all over VDSM.

phoracek at redhat.com phoracek at redhat.com
Thu Dec 17 12:38:37 UTC 2015


Petr Horáček has posted comments on this change.

Change subject: net: MTU should be an integer all over VDSM.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

nice patch, just a nit. do we have something similar for vlans?

https://gerrit.ovirt.org/#/c/50657/1//COMMIT_MSG
Commit Message:

Line 6: 
Line 7: net: MTU should be an integer all over VDSM.
Line 8: 
Line 9: It should be serialized as such and be converted to a string only
Line 10: when written to files, and immedietly upon the start of setupNetworks
immediately
Line 11: API call.
Line 12: 
Line 13: Change-Id: Id7ba110d85b8ebd459c29ea438a68b8e55ccb1da


https://gerrit.ovirt.org/#/c/50657/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 975: 
Line 976:         if 'mtu' not in attrs:
Line 977:             attrs['mtu'] = DEFAULT_MTU
Line 978:         else:
Line 979:             attrs['mtu'] = int(attrs['mtu'])
this function should add missing defaults, not convert passed attributes
Line 980: 
Line 981: 
Line 982: def setSafeNetworkConfig():
Line 983:     """Declare current network configuration as 'safe'"""


-- 
To view, visit https://gerrit.ovirt.org/50657
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id7ba110d85b8ebd459c29ea438a68b8e55ccb1da
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list