Change in vdsm[master]: supervdsm: moving nics between bonds
ibarkan at redhat.com
ibarkan at redhat.com
Thu Dec 17 09:13:16 UTC 2015
Ido Barkan has posted comments on this change.
Change subject: supervdsm: moving nics between bonds
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/configurators/ifcfg.py
File lib/vdsm/network/configurators/ifcfg.py:
Line 125: self.runningConfig.setBonding(
Line 126: bond.name, {'options': bond.options,
Line 127: 'nics': [slave.name for slave in bond.slaves]})
Line 128:
Line 129: def remove_slaves(self, removed_slaves, _netinfo):
> If this is now a configurator API, the superclass and all other configurato
yea, we neglect iproute2 and py_route_two because nobody really use them. but you are right,
Line 130: for nic in removed_slaves:
Line 131: ifdown(nic) # So that no users will be detected for it.
Line 132: Nic(nic, self, _netinfo=_netinfo).remove()
Line 133:
--
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes
More information about the vdsm-patches
mailing list