Change in vdsm[master]: supervdsm: moving nics between bonds

ibarkan at redhat.com ibarkan at redhat.com
Thu Dec 17 08:12:54 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: supervdsm: moving nics between bonds
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

We need a functional test for this. It is easy to do. just make sure (by playing with the bond names that you reproduce the order of adding-an-removal you need)

https://gerrit.ovirt.org/#/c/50596/1//COMMIT_MSG
Commit Message:

Line 9: an
a


https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 687: ,
        :                                 _netinfo=_netinfo
this line break is unrelated, right?


https://gerrit.ovirt.org/#/c/50596/1/lib/vdsm/network/models.py
File lib/vdsm/network/models.py:

Line 262: if not existing_bond_name or new_bond_name == existing_bond_name:
I would split this or expression into 2 tests (as done for next 2 tests) for the sake of readability.


Line 268: bond['remove'] == 'true':
can 'remove' be other then 'true'?


-- 
To view, visit https://gerrit.ovirt.org/50596
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia43fbfe90d1335ed4a740a1bc4f09610da2ecdce
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marcin Mirecki <mmirecki at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list