Change in vdsm[master]: net: add documentation for setupNetworks rollback mechanism.

danken at redhat.com danken at redhat.com
Thu Dec 17 07:54:16 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: add documentation for setupNetworks rollback mechanism.
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/50261/1/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 914: excepted
I don't think that the English verb means what you want here.
"handled", maybe?


https://gerrit.ovirt.org/#/c/50261/1/vdsm/API.py
File vdsm/API.py:

Line 1522: cleanup is done.
I don't understand this text. At this point, we are about to try to do a rollback. Before the next line succeeds, cleanup is not yet done.


-- 
To view, visit https://gerrit.ovirt.org/50261
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I4f7d66f9612ed6762fa80e7aa9e57d914dd65f34
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list