Change in vdsm[master]: storage: add getHostId to DomainMonitor

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 16 22:53:49 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: storage: add getHostId to DomainMonitor
......................................................................


Patch Set 3:

(1 comment)

https://gerrit.ovirt.org/#/c/50630/3//COMMIT_MSG
Commit Message:

Line 8: 
Line 9: Some SDM verbs need to acquire the domainLock during their job.  In
Line 10: order to do this they must be passed the domain's hostId property.  An
Line 11: easy way to expose this is to add a getHostId method to the
Line 12: DomainMonitor.
Please explain why not use getPools()[0].id
Line 13: 
Line 14: Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c


-- 
To view, visit https://gerrit.ovirt.org/50630
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I21c3c59678ad6a7d6087d05c7109ec4087cbb09c
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Ala Hino <ahino at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list