Change in vdsm[master]: sdm: add create_volume_container API stub

alitke at redhat.com alitke at redhat.com
Wed Dec 16 16:20:35 UTC 2015


Adam Litke has posted comments on this change.

Change subject: sdm: add create_volume_container API stub
......................................................................


Patch Set 4:

(4 comments)

https://gerrit.ovirt.org/#/c/50220/4//COMMIT_MSG
Commit Message:

Line 3: AuthorDate: 2015-12-09 11:02:03 -0500
Line 4: Commit:     Adam Litke <alitke at redhat.com>
Line 5: CommitDate: 2015-12-14 09:22:35 -0500
Line 6: 
Line 7: sdm: add create_volume_container API stub
> SDM.create_volume
Done
Line 8: 
Line 9: Change-Id: I1ff2656f2dd427812e557e6587429759a9c0a845


https://gerrit.ovirt.org/#/c/50220/4/client/vdsClient.py
File client/vdsClient.py:

Line 1952:     def unregisterSecrets(self, args):
Line 1953:         res = self.s.unregisterSecrets(args)
Line 1954:         return res['status']['code'], res['status']['message']
Line 1955: 
Line 1956:     def sdm_create_volume(self, args):
> You can check argument types and numbers using validateArgTypes.
Done
Line 1957:         job_id = args[0]
Line 1958:         try:
Line 1959:             vol_info = json.loads(args[1])
Line 1960:         except ValueError:


https://gerrit.ovirt.org/#/c/50220/4/lib/api/vdsmapi-schema.json
File lib/api/vdsmapi-schema.json:

Line 8696: # @SDM:
Line 8697: #
Line 8698: # This namespace is for SDM (storage domain manager) functions.
Line 8699: #
Line 8700: # Since: 4.16.0
> 4.18
Done
Line 8701: ##
Line 8702: {'class': 'SDM'}
Line 8703: 
Line 8704: ##


Line 8727: # @initial_size:   #optional If specified, initial size of volume in bytes
Line 8728: #                  (as string). Allowed only when creating thin provisioned
Line 8729: #                  volume on block storage.
Line 8730: #
Line 8731: # Since: 4.18.0
> Lets use 4.18, the bugfix version is very hard to use, you cannot merge pat
Done
Line 8732: ##
Line 8733: {'type': 'CreateVolumeInfo',
Line 8734:  'data': {'sd_id': 'UUID', 'img_id': 'UUID', 'vol_id': 'UUID',
Line 8735:           'virtual_size': 'int', 'vol_format': 'VolumeFormat',


-- 
To view, visit https://gerrit.ovirt.org/50220
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1ff2656f2dd427812e557e6587429759a9c0a845
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list