Change in vdsm[master]: contrib: Simple jsonrpc client

nsoffer at redhat.com nsoffer at redhat.com
Wed Dec 16 15:02:32 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: contrib: Simple jsonrpc client
......................................................................


Patch Set 6:

(1 comment)

https://gerrit.ovirt.org/#/c/35181/6/contrib/jsonrpc
File contrib/jsonrpc:

Line 165:     sslctx = SSLContext(key_file=KEYFILE, cert_file=CERTFILE,
Line 166:                         ca_certs=CACERT, protocol=ssl.PROTOCOL_TLSv1)
Line 167: 
Line 168:     return stompreactor.StandAloneRpcClient(options.host, PORT,
Line 169:                                             'jms.topic.vdsm_requests',
> This desired approach to use something unique for response queue to limit c
Agree, then delete DESTINATION.

To make it clear, lets do something like:

    topic=uuid.uui4()

And comment why we need unique topic.
Line 170:                                             str(uuid4()), sslctx,
Line 171:                                             lazy_start=False)
Line 172: 
Line 173: 


-- 
To view, visit https://gerrit.ovirt.org/35181
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6273eabf6f3601602659d1e4e748d8025ae8084
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini at redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <toni+ovirt at midokura.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Jenkins CI RO
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list