Change in vdsm[master]: net: Correctly apply MTU values on networks

danken at redhat.com danken at redhat.com
Wed Dec 16 06:55:13 UTC 2015


Dan Kenigsberg has posted comments on this change.

Change subject: net: Correctly apply MTU values on networks
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/50397/3/lib/vdsm/network/api.py
File lib/vdsm/network/api.py:

Line 902: _complement_net_defaults
in a future patch - rename to _canonize_networks() as you plan to do str->int translation there.


Line 975: att
att and attr represent the same thing, and as such, should have the same name. The name should better be 'attrs' as it is multiple attributes of the network.

btw, I find the following simpler:

    for attrs in six.itervalues(nets):
        if attrs.get('remove'):
            continue

        if 'mtu' not in attrs:
            attr['mtu'] = DEFAULT_MTU

your call.


-- 
To view, visit https://gerrit.ovirt.org/50397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list