Change in vdsm[master]: jobs: Only report progress if set

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 15 16:57:10 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: jobs: Only report progress if set
......................................................................


jobs: Only report progress if set

Not all Jobs have deterministic progress and some jobs will complete so
quickly that progress updates are not practical.  If progress is not
available do not report it.  Consumers of the Job info could choose to
render a non-deterministic progress indication (barber pole, or spinning
indicator) instead of a regular progress bar.

We expect all jobs to start without any progress to report since they
may be pending (waiting for a worker thread) or initializing (taking
locks).  Jobs that can provide progress information will start to report
later.  Jobs that do not support progress need not implement anything as
the default behavior of Job is to never report progress.

Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50355
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Tested-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Francesco Romani <fromani at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Continuous-Integration: Jenkins CI
Reviewed-by: Shahar Havivi <shavivi at redhat.com>
---
M lib/vdsm/jobs.py
M tests/jobsTests.py
2 files changed, 20 insertions(+), 5 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Verified; Looks good to me, approved
  Shahar Havivi: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Francesco Romani: Looks good to me, but someone else must approve



-- 
To view, visit https://gerrit.ovirt.org/50355
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3cc8b66d825676045fbcb8431bb3cf11885ff02b
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list