Change in vdsm[master]: jobs: Add error property

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 15 16:56:37 UTC 2015


Nir Soffer has submitted this change and it was merged.

Change subject: jobs: Add error property
......................................................................


jobs: Add error property

When a Job encounters an error, there should be a standardized way for
that error to be stored so that code working with Job objects has a
standard way to propagate the error.

Add an 'error' property to the job class which is None by default but
can contain an instance of utils.GeneralException or one of its
decendants.  If error is set, the dictionary returned by the call to
info() will contain an 'error' key.  The value of this key is a status
code (containing a standard vdsm code and message).

Change-Id: I3f6e27beeeecd69db1673e5168524b0ce94f2e9e
Signed-off-by: Adam Litke <alitke at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50354
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Shahar Havivi <shavivi at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Continuous-Integration: Jenkins CI
---
M lib/vdsm/jobs.py
M tests/jobsTests.py
2 files changed, 25 insertions(+), 7 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Adam Litke: Verified
  Nir Soffer: Looks good to me, approved
  Shahar Havivi: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests



-- 
To view, visit https://gerrit.ovirt.org/50354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I3f6e27beeeecd69db1673e5168524b0ce94f2e9e
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Pablo Iranzo Gómez
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list