Change in vdsm[master]: jobs: Rename the FAILED constant to "failed"

shavivi at redhat.com shavivi at redhat.com
Tue Dec 15 12:27:57 UTC 2015


Shahar Havivi has posted comments on this change.

Change subject: jobs: Rename the FAILED constant to "failed"
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.ovirt.org/#/c/50503/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 32:     RUNNING = 'running'  # Job is running
Line 33:     DONE = 'done'        # Job has finished successfully
Line 34:     ABORTED = 'aborted'  # Job was aborted by user request
Line 35:     FAILED = 'failed'    # Job has failed
Line 36: 
Engine v2v is using the value of these fields values and compare them to the values in V2VJobInfo.JobStatus enum.
Changing that will need an engine change - and can cause backward comparability issues.
Maybe we can change the field name to ERROR.
Line 37: 
Line 38: class ClientError(Exception):
Line 39:     ''' Base class for client error '''
Line 40:     name = None


-- 
To view, visit https://gerrit.ovirt.org/50503
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I047ed344867d461d7343e929f9756f798f487b4c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list