Change in vdsm[master]: jobs: Remove duplication in STATUS constants

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 15 10:56:02 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: jobs: Remove duplication in STATUS constants
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/50500/1/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 26: _lock = threading.Lock()
Line 27: _jobs = {}
Line 28: 
Line 29: 
Line 30: class STATUS:
> wrote this before to check the followup patch(es). If you believe this make
Not sure if we need this comment.
Line 31:     RUNNING = 'running'  # Job is running
Line 32:     ABORTED = 'aborted'  # Job was aborted by user request
Line 33:     FAILED = 'error'     # Job has failed
Line 34:     DONE = 'done'        # Job has finished successfully


-- 
To view, visit https://gerrit.ovirt.org/50500
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3252f79d5a58a8ea694bbbbeef753d3eb93580b8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list