Change in vdsm[master]: v2v: support for importing Xen VMs via libvirt on RHEL hosts

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 15 10:20:36 UTC 2015


Nir Soffer has posted comments on this change.

Change subject: v2v: support for importing Xen VMs via libvirt on RHEL hosts
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.ovirt.org/#/c/49505/1/vdsm/v2v.py
File vdsm/v2v.py:

Line 326
Line 327
Line 328
Line 329
Line 330
> Don't we want to initialize all variables in the __init__ method?
Yes, but this moved to the Command class. I suggest you continue this patch when we finish to refactor the code.


-- 
To view, visit https://gerrit.ovirt.org/49505
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If544c0247003b6bc7189f72130553b9402dc915d
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list