Change in vdsm[master]: jobs: Remove duplication in STATUS constants

nsoffer at redhat.com nsoffer at redhat.com
Tue Dec 15 10:07:42 UTC 2015


Nir Soffer has uploaded a new change for review.

Change subject: jobs: Remove duplication in STATUS constants
......................................................................

jobs: Remove duplication in STATUS constants

We were duplicating the names and the values of the constants. Move the
description of the constants to the same line.

Change-Id: I3252f79d5a58a8ea694bbbbeef753d3eb93580b8
Signed-off-by: Nir Soffer <nsoffer at redhat.com>
---
M lib/vdsm/jobs.py
1 file changed, 4 insertions(+), 10 deletions(-)


  git pull ssh://gerrit.ovirt.org:29418/vdsm refs/changes/00/50500/1

diff --git a/lib/vdsm/jobs.py b/lib/vdsm/jobs.py
index 8c7c30e..3be8f60 100644
--- a/lib/vdsm/jobs.py
+++ b/lib/vdsm/jobs.py
@@ -28,16 +28,10 @@
 
 
 class STATUS:
-    '''
-    RUNNING: Job is running
-    ABORTED: Job aborted by user request
-    FAILED: Job failed and no longer running
-    DONE: Job has finished successfully
-    '''
-    RUNNING = 'running'
-    ABORTED = 'aborted'
-    FAILED = 'error'
-    DONE = 'done'
+    RUNNING = 'running'  # Job is running
+    ABORTED = 'aborted'  # Job was aborted by user request
+    FAILED = 'error'     # Job has failed
+    DONE = 'done'        # Job has finished successfully
 
 
 class ClientError(Exception):


-- 
To view, visit https://gerrit.ovirt.org/50500
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3252f79d5a58a8ea694bbbbeef753d3eb93580b8
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer at redhat.com>


More information about the vdsm-patches mailing list