Change in vdsm[ovirt-3.5]: virt: vm: Update time on VM after resume

mzamazal at redhat.com mzamazal at redhat.com
Mon Dec 14 16:46:22 UTC 2015


Milan Zamazal has posted comments on this change.

Change subject: virt: vm: Update time on VM after resume
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/50456/1//COMMIT_MSG
Commit Message:

Line 35: with libvirt developers.
Line 36: 
Line 37: Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Line 38: Bug-Url: https://bugzilla.redhat.com/1287620
Line 39: Signed-off-by: Milan Zamazal <mzamazal at redhat.com>
> this seems to miss a few gerrit tags - I added them back manually. Maybe ba
My fault: I wasn't sure they should remain there, so I removed them.  Will leave them next time. :)


https://gerrit.ovirt.org/#/c/50456/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2782:                 self.log.debug(template, "QEMU agent unresponsive")
Line 2783:             elif code == libvirt.VIR_ERR_NO_SUPPORT:
Line 2784:                 self.log.debug(template, "Not supported")
Line 2785:             else:
Line 2786:                 self.log.error(template, e)
> we don't handle disconnected domain anymore - but we should, for the same r
Thank you for fixing that!
Line 2787:         else:
Line 2788:             self.log.debug('Time updated to: %d.%09d', seconds, nseconds)
Line 2789: 
Line 2790:     def shutdown(self, delay, message, reboot, timeout, force):


-- 
To view, visit https://gerrit.ovirt.org/50456
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ieb583cd5d21e56d7730b0ba21d75ed93b9d34025
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: ovirt-3.5
Gerrit-Owner: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Milan Zamazal <mzamazal at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list