Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

alkaplan at redhat.com alkaplan at redhat.com
Mon Dec 14 16:35:34 UTC 2015


Alona Kaplan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/50372/2/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2011:         self.log.info("Hotplug NIC xml: %s", nicXml)
Line 2012: 
Line 2013:         try:
Line 2014:             if nic.is_hostdevice:
Line 2015:                 hostdev.detach_detachable(params[hwclass.HOSTDEV])
Traceback (most recent call last):
  File "/usr/lib/python2.7/site-packages/yajsonrpc/__init__.py", line 527, in _serveRequest
    res = method(**params)
  File "/usr/share/vdsm/rpc/Bridge.py", line 279, in _dynamicMethod
    result = fn(*methodArgs)
  File "/usr/share/vdsm/API.py", line 431, in hotplugNic
    return curVm.hotplugNic(params)
  File "/usr/share/vdsm/virt/vm.py", line 2015, in hotplugNic
    hostdev.detach_detachable(params[hwclass.HOSTDEV])
KeyError: 'hostdev'
Line 2016:             self._dom.attachDevice(nicXml)
Line 2017:         except libvirt.libvirtError as e:
Line 2018:             self.log.exception("Hotplug failed")
Line 2019:             nicXml = hooks.after_nic_hotplug_fail(


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list