Change in vdsm[master]: [WIP] vdsm standard CI arrangement

dcaro at redhat.com dcaro at redhat.com
Mon Dec 14 14:47:23 UTC 2015


David Caro has posted comments on this change.

Change subject: [WIP] vdsm standard CI arrangement
......................................................................


Patch Set 25:

(2 comments)

https://gerrit.ovirt.org/#/c/48268/25/automation/check-merged.sh
File automation/check-merged.sh:

Line 16: 
Line 17: # Generate coverage report in HTML format
Line 18: pushd tests
Line 19: coverage html -d "$EXPORT_DIR/htmlcov"
Line 20: popd
> This is the ci script that david will run. We don't have to put our code in
That's not true, all the code that's in this script is your's, said that, you can refactor the code in here and move any/all of it to another place (like that check-common.sh)
Line 21: 
Line 22: # Run functional tests


Line 19: coverage html -d "$EXPORT_DIR/htmlcov"
Line 20: popd
Line 21: 
Line 22: # Run functional tests
Line 23: ./automation/lago-control.sh
> We don't want to run the functional tests here, I'm suggesting a separate j
There will be no separated jenkins job (if that's what you mean), there's only check-patch and check-merge, you decide what you want to run on each.


-- 
To view, visit https://gerrit.ovirt.org/48268
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I463c754bd70679449d0841caeef1b845b5709f1c
Gerrit-PatchSet: 25
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: David Caro <dcaro at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list