Change in vdsm[master]: jobs: Add error property

alitke at redhat.com alitke at redhat.com
Mon Dec 14 14:27:21 UTC 2015


Adam Litke has posted comments on this change.

Change subject: jobs: Add error property
......................................................................


Patch Set 2: Verified+1

(1 comment)

Verified with unit tests.

https://gerrit.ovirt.org/#/c/50354/2/lib/vdsm/jobs.py
File lib/vdsm/jobs.py:

Line 99:                'progress': self.progress,
Line 100:                'job_type': self.job_type}
Line 101: 
Line 102:         if self.error:
Line 103:             ret['error'] = self.error.response()
> It looks like this is api change but schema is not updated.
We don't have a schema for this yet since this code is not actually exposed to the public.  I'll add a note in https://gerrit.ovirt.org/#/c/49450 so we remember to add it.
Line 104: 
Line 105:         return ret
Line 106: 
Line 107:     def abort(self):


-- 
To view, visit https://gerrit.ovirt.org/50354
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I3f6e27beeeecd69db1673e5168524b0ce94f2e9e
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Adam Litke <alitke at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Pablo Iranzo Gómez
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list