Change in vdsm[master]: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR

danken at redhat.com danken at redhat.com
Mon Dec 14 13:04:52 UTC 2015


Dan Kenigsberg has submitted this change and it was merged.

Change subject: pyflakes: drop a too-clever SKIP_PYFLAKES_ERR
......................................................................


pyflakes: drop a too-clever SKIP_PYFLAKES_ERR

Commit 6177a169fc84576 attempted to ignore a false pyflakes error with a
too-clever shell constract. Modern pyflake no longer complain, but the
code causes the pyflakes target to ignore real failures.

Change-Id: If5e797335d73af50e6ac4c8e1542adc4b6e4f07f
Signed-off-by: Dan Kenigsberg <danken at redhat.com>
Reviewed-on: https://gerrit.ovirt.org/50109
Continuous-Integration: Jenkins CI
Reviewed-by: Nir Soffer <nsoffer at redhat.com>
Reviewed-by: Piotr Kliczewski <piotr.kliczewski at gmail.com>
---
M Makefile.am
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  Piotr Kliczewski: Looks good to me, but someone else must approve
  Nir Soffer: Looks good to me, but someone else must approve
  Jenkins CI: Passed CI tests
  Dan Kenigsberg: Verified; Looks good to me, approved



-- 
To view, visit https://gerrit.ovirt.org/50109
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: If5e797335d73af50e6ac4c8e1542adc4b6e4f07f
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski at gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>


More information about the vdsm-patches mailing list