Change in vdsm[master]: net: support hot(un)plugNic for SRIOV network devices.

ibarkan at redhat.com ibarkan at redhat.com
Mon Dec 14 11:38:52 UTC 2015


Ido Barkan has posted comments on this change.

Change subject: net: support hot(un)plugNic for SRIOV network devices.
......................................................................


Patch Set 1:

(2 comments)

https://gerrit.ovirt.org/#/c/50372/1/vdsm/virt/vm.py
File vdsm/virt/vm.py:

Line 2011:         self.log.info("Hotplug NIC xml: %s", nicXml)
Line 2012: 
Line 2013:         try:
Line 2014:             if nic.is_hostdevice:
Line 2015:                 hostdev.detach_detachable(params.get(hwclass.HOSTDEV))
> Why get()? If hostdev is missing from a hostdev device, we should explode h
Done
Line 2016:             self._dom.attachDevice(nicXml)
Line 2017:         except libvirt.libvirtError as e:
Line 2018:             self.log.exception("Hotplug failed")
Line 2019:             nicXml = hooks.after_nic_hotplug_fail(


Line 2273: 
Line 2274:         try:
Line 2275:             self._dom.detachDevice(nicXml)
Line 2276:             self._waitForDeviceRemoval(nic)
Line 2277:             if nic and nic.is_hostdevice:
> Same issue: can nic ever be None here?
Done
Line 2278:                 hostdev.reattach_detachable(nic.hostdev)
Line 2279:         except HotunplugTimeout as e:
Line 2280:             self.log.error("%s", e)
Line 2281:             return response.error('hotunplugNic', "%s" % e)


-- 
To view, visit https://gerrit.ovirt.org/50372
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5997a5cc777edf6dc422495a0eb5aeff1d1c9440
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list