Change in vdsm[master]: caps/lib: move CPU architecture details to lib/cpuarch

mpolednik at redhat.com mpolednik at redhat.com
Mon Dec 14 11:07:08 UTC 2015


Martin Polednik has posted comments on this change.

Change subject: caps/lib: move CPU architecture details to lib/cpuarch
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.ovirt.org/#/c/49972/2/lib/vdsm/cpuarch.py
File lib/vdsm/cpuarch.py:

Line 105:     else:
Line 106:         return current()
Line 107: 
Line 108: 
Line 109: def _cpu_arch_to_architecture(target_arch):
> This is confusing. In this module (cpuarch), you are using the term arch an
It does not come from platform.machine(); the architecture is used to refer to the Architecture class and arch/cpu_arch to the real architecture.
Line 110:     mapping = {
Line 111:         'x86_64': Architecture.X86_64,
Line 112:         'ppc64': Architecture.PPC64,
Line 113:         'ppc64le': Architecture.PPC64LE


-- 
To view, visit https://gerrit.ovirt.org/49972
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I46bb51769562fbb9d816d190c2aebfd0660cc3b0
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik at redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list