Change in vdsm[master]: net: Correctly apply MTU values on networks

edwardh at redhat.com edwardh at redhat.com
Mon Dec 14 10:24:09 UTC 2015


Edward Haas has posted comments on this change.

Change subject: net: Correctly apply MTU values on networks
......................................................................


Patch Set 1:

IMO, having independent guards on both Engine and VDSM is preferred.
Either handle defaults at the VDSM side (like in the current patch) or to validate the network command and assure MTU exist, otherwise to fail the setup.

-- 
To view, visit https://gerrit.ovirt.org/50397
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Iba24363f5b9ea70392a68885cf5374800ab58549
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Alona Kaplan <alkaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh at redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Ondřej Svoboda <osvoboda at redhat.com>
Gerrit-Reviewer: Petr Horáček <phoracek at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: No


More information about the vdsm-patches mailing list