Change in vdsm[master]: Makefile: use tox to run make pep8 and pyflakes

ybronhei at redhat.com ybronhei at redhat.com
Mon Dec 14 08:08:52 UTC 2015


Yaniv Bronhaim has posted comments on this change.

Change subject: Makefile: use tox to run make pep8 and pyflakes
......................................................................


Patch Set 4:

(6 comments)

https://gerrit.ovirt.org/#/c/49952/4/tox.ini
File tox.ini:

Line 3: skipsdist = true
Line 4: [testenv:py27]
Line 5: deps =
Line 6:     pyflakes==0.9.2
Line 7:     pep8==1.5.6
> Sadly we cannot use this version, we have to fix too many warnings before w
which is 1.5.7
Line 8: commands=


https://gerrit.ovirt.org/#/c/49952/4/tox.sh
File tox.sh:

Line 24: 
Line 25: if [ 'pyflakes' = "$1" ]; then
Line 26:     (find . -path './.tox' -prune -type f -o \
Line 27:         -path './.git' -prune -type f -o \
Line 28:         -name '*.py' -o -name '*.py.in' && echo "${WHITELIST[@]}") | \
> .py.in files were removed in master, please check only .py files.
only rebase. whitelist includes py files with no extension afaiu
Line 29:         xargs pyflakes | grep -w -v "${SKIP_PYFLAKES_ERR}" | \
Line 30:         while read LINE; do echo "$LINE"; false; done
Line 31: fi
Line 32: 


Line 30:         while read LINE; do echo "$LINE"; false; done
Line 31: fi
Line 32: 
Line 33: if [ 'pep8' = "$1" ]; then
Line 34:     for x in ${PEP8_BLACKLIST[@]}; do \
> ${PEP8_BLACKLIST[@]} ?
its a list of files that you don't want to pep8. but probably they pass by now. you can decide in following patch if you want to remove it, but here better to leave same behavior or rebase this one above removal patch for that
Line 35:     exclude="$${exclude},$${x}" ; \
Line 36:         done ; \
Line 37:         pep8 --exclude="$${exclude}" --exclude='.tox/*' \
Line 38:         --filename '*.py,*.py.in' . \


Line 34:     for x in ${PEP8_BLACKLIST[@]}; do \
Line 35:     exclude="$${exclude},$${x}" ; \
Line 36:         done ; \
Line 37:         pep8 --exclude="$${exclude}" --exclude='.tox/*' \
Line 38:         --filename '*.py,*.py.in' . \
> .py.in files were removed in master, please check only .py files.
again, only rebase
Line 39:         "${WHITELIST[@]}"


https://gerrit.ovirt.org/#/c/49952/4/vdsm.spec.in
File vdsm.spec.in:

Line 96
Line 97
Line 98
Line 99
Line 100
> We don't need now pyflakes and python-pep8
I'll remove this with_check scope in following patch


Line 98: %if 0%{?with_check}
Line 99: BuildRequires: pyflakes
Line 100: BuildRequires: python-pep8
Line 101: BuildRequires: python-tox
Line 102: %endif
this requirement shouldn't be under the with_check
Line 103: 
Line 104: BuildRequires: systemd-units
Line 105: 
Line 106: Requires: ethtool


-- 
To view, visit https://gerrit.ovirt.org/49952
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id583de2d411bb5bcd0f717f569d2961b555334c9
Gerrit-PatchSet: 4
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken at redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer at redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei at redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan at redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation at ovirt.org>
Gerrit-HasComments: Yes


More information about the vdsm-patches mailing list